Make http base path configurable #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomist
bot
added
the
auto-branch-delete:on-close
cdupuis
added
changelog:added
atomist
bot
added
auto-merge-method:merge
cdupuis
added
the
auto-branch-delete:on-close
ddgenome
reviewed
Feb 9, 2021
There was a problem hiding this comment.
Looks good. Should configuration.http.base be defined here:
automation-client/lib/configuration.ts
Line 162 in 5c69883
Isn't that in the automation-client/lib/configuration.ts Line 167 in 5c69883 |
|
Indeed it is. |
atomist bot
pushed a commit
that referenced
this pull request
Feb 9, 2021
- #661 to added [atomist:generated]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.