-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal to add windows support to the custom target functionality #8
proposal to add windows support to the custom target functionality #8
Conversation
Hi @Brookke, I can't get this to run: |
@MarvinJWendt I have made some changes, could you also share your "experimenting" code if you don't mind and I can test my side :) |
Codecov Report
@@ Coverage Diff @@
## main #8 +/- ##
===========================================
- Coverage 26.04% 10.30% -15.74%
===========================================
Files 4 5 +1
Lines 96 165 +69
===========================================
- Hits 25 17 -8
- Misses 69 146 +77
Partials 2 2
Continue to review full report at Codecov.
|
Hi @Brookke, the experimenting code is actually not relevant. It was a simple hello world, but the code didn't compile 😅 |
Hopefully the code should compile now. I have done some testing on a windows vm and it seems to work. The test will fail as the underlying calls are different on windows. |
# Conflicts: # cursor.go
Hi @Brookke, sorry for the long wait. I am currently looking into fixing the tests :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR :)
No description provided.