Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal to add windows support to the custom target functionality #8

Merged
merged 8 commits into from
Jun 4, 2022

Conversation

Brookke
Copy link
Contributor

@Brookke Brookke commented Mar 16, 2022

No description provided.

@MarvinJWendt
Copy link
Member

Hi @Brookke, I can't get this to run:

image

@Brookke
Copy link
Contributor Author

Brookke commented Apr 16, 2022

@MarvinJWendt I have made some changes, could you also share your "experimenting" code if you don't mind and I can test my side :)

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #8 (d46366e) into main (b809a13) will decrease coverage by 15.73%.
The diff coverage is 1.35%.

@@             Coverage Diff             @@
##             main       #8       +/-   ##
===========================================
- Coverage   26.04%   10.30%   -15.74%     
===========================================
  Files           4        5        +1     
  Lines          96      165       +69     
===========================================
- Hits           25       17        -8     
- Misses         69      146       +77     
  Partials        2        2               
Impacted Files Coverage Δ
cursor.go 33.33% <ø> (-53.34%) ⬇️
cursor_test_linux.go 0.00% <0.00%> (ø)
utils.go 0.00% <ø> (ø)
cursor_windows.go 27.27% <16.66%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b809a13...d46366e. Read the comment docs.

@MarvinJWendt
Copy link
Member

Hi @Brookke, the experimenting code is actually not relevant. It was a simple hello world, but the code didn't compile 😅

@Brookke
Copy link
Contributor Author

Brookke commented Apr 18, 2022

Hi @Brookke, the experimenting code is actually not relevant. It was a simple hello world, but the code didn't compile 😅

Hopefully the code should compile now. I have done some testing on a windows vm and it seems to work. The test will fail as the underlying calls are different on windows.

@MarvinJWendt
Copy link
Member

Hi @Brookke, sorry for the long wait. I am currently looking into fixing the tests :)

Copy link
Member

@MarvinJWendt MarvinJWendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR :)

@MarvinJWendt MarvinJWendt merged commit 5b50ff4 into atomicgo:main Jun 4, 2022
@MarvinJWendt MarvinJWendt added the feature New feature or request label Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants