Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom writer for area #7

Merged
merged 8 commits into from
Jun 18, 2023

Conversation

Brookke
Copy link
Contributor

@Brookke Brookke commented Mar 16, 2022

This is needed in order to support pterm/pterm#261

@MarvinJWendt
Copy link
Member

Hi @Brookke, I just saw this PR again, is it done? It's currently marked as a draft, so I didn't review it :)

Copy link
Collaborator

@lammel lammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and should allow flexible use on any writer

area.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Merging #7 (4e7ffdd) into main (da2c261) will decrease coverage by 0.25%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main      #7      +/-   ##
========================================
- Coverage   4.31%   4.06%   -0.25%     
========================================
  Files          4       4              
  Lines        116     123       +7     
========================================
  Hits           5       5              
- Misses       110     117       +7     
  Partials       1       1              
Impacted Files Coverage Δ
area.go 0.00% <0.00%> (ø)
cursor.go 33.33% <0.00%> (ø)
cursor_test_linux.go 0.00% <0.00%> (ø)
utils.go 0.00% <ø> (ø)

@MarvinJWendt MarvinJWendt marked this pull request as ready for review June 18, 2023 16:51
@MarvinJWendt MarvinJWendt merged commit a812c8e into atomicgo:main Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants