Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better package linting #1018

Open
Polleps opened this issue Nov 21, 2024 · 0 comments · May be fixed by #1025
Open

Better package linting #1018

Polleps opened this issue Nov 21, 2024 · 0 comments · May be fixed by #1025
Assignees
@Polleps
Labels
ci Github actions / e2e tests / build / etc @tomic/cli @tomic/cli @tomic/create-template @tomic/lib @tomic/lib @tomic/react @tomic/react @tomic/svelte @tomic/svelte

Comments

@Polleps
Copy link
Member

Polleps commented Nov 21, 2024 •
edited
Loading

There are certain steps that need to be taken to make a JavaScript package easily usable in a wide range of environments. For instance, there are some subtle quirks that aren’t immediately apparent, such as ensuring that the type export rule in package.json precedes the others.

We should add publint and are my trypes wrong checks to the packages and to the CI to make sure our packages are up to standard.
@Polleps Polleps self-assigned this Nov 21, 2024
@Polleps Polleps changed the title Better package health checks Better package linting Nov 21, 2024
@joepio joepio added the ci Github actions / e2e tests / build / etc label Nov 21, 2024
Polleps added a commit that referenced this issue Dec 2, 2024
@Polleps
Switch to tsup for package builds + enable noImplicitAny #1018
325ae2e
@Polleps Polleps linked a pull request Dec 2, 2024 that will close this issue
Open
3 tasks
Polleps added a commit that referenced this issue Dec 2, 2024
@Polleps
Enable noImplicitAny For @tomic/react #1018
a9b83fd
Polleps added a commit that referenced this issue Dec 9, 2024
@Polleps
Switch to tsup for package builds + enable noImplicitAny #1018
42d20d0
Polleps added a commit that referenced this issue Dec 9, 2024
@Polleps
Enable noImplicitAny For @tomic/react #1018
41471d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Polleps Polleps

Labels
ci Github actions / e2e tests / build / etc @tomic/cli @tomic/cli @tomic/create-template @tomic/lib @tomic/lib @tomic/react @tomic/react @tomic/svelte @tomic/svelte
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to tsup for package builds + enable noImplicitAny #1018 atomicdata-dev/atomic-server
2 participants
@joepio @Polleps