This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Move special Markdown line break whitespace handling to configuration #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,9 @@ module.exports = | |||
| scopes: | |||
| '.source.jade': | |||
| default: false | |||
| ignoreMarkdownLineBreak: | |||
| type: 'boolean' | |||
There was a problem hiding this comment.
I think this needs a description or an improved name, it would take me awhile to think about whether checked or unchecked will trim trailing whitespace in markdown files since "ignoring the line break" means removing it in the context of this package.
Maybe something like:
keepTrailingTwoSpacesInMarkdownFileswith a description like Markdown treats two spaces at the end of a line as a line break
Thoughts?
There was a problem hiding this comment.
Changed the name to keepMarkdownLineBreakWhitespace and added the following description:
Markdown uses two or more spaces at the end of a line to signify a line break. Enable this option to keep this whitespace, even if other settings would remove it.
| keepMarkdownLineBreakWhitespace: | ||
| type: 'boolean' | ||
| default: true | ||
| description: ''' |
There was a problem hiding this comment.
What a nice description 👍
|
👍 🚢 |
lee-dohm
added a commit
that referenced
this pull request
Jul 30, 2015
Move special Markdown line break whitespace handling to configuration
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68, #80
Moving it to a configuration setting allows it to be turned off.