This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix spaces-to-tabs and tabs-to-spaces to use "tab stops" correctly #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these corrections, the tabs-to-spaces and spaces-to-tabs conversions match the layout of the core editor display, as well as are capable of going round-trip (spaces -> tabs -> spaces) without losing the visual positions of the non-whitespace characters.
I also had to beef up the specs a little, since they would fail on non-Travis (IOW, machines that had Atom installed and had some personalization) machines. It is just basic hygiene of setting parameters back to expected values before starting the next test. (More could probably be done, but what I have now appears to be fairly robust.)
I changed the specs to reflect the new expected behavior.
No documentation changes are necessary.
Animation of the corrected behavior: