This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Typing in font family deletes characters #1062
Comments
captbaritone
added a commit
to captbaritone/atom
that referenced
this issue
Dec 5, 2018
In atom@7a5d727 the 'set-user-settings' callback was changed so that it nolonger returned the promise created by `ConfigFile.update()`. This meant that the logic in [`ApplicateDelegate.onDidChangeUserSetting()`](https://github.com/atom/atom/blob/5f0231b/src/application-delegate.js#L193-L206) which uses `.pendingSettingUpdateCount` to avoid triggering in response to calls to ApplicationDelegate.setUserSettings` was no longer effective. I noticed this when updating settings via the setting view. If you type at just the right (wrong?) cadence, you'll notice that your input can get updated with stale values. Something like this: ``` You type "a" "b" "c" config.set "a" "ab" "ac" config.observe "a" "ab" "ac" Input value "a" "ab" "a" "ac" "ab" "ac" ``` It's possible that is the same as atom/settings-view#1062 After this change typing in settings input seems to behave as expected.
|
@lukepighetti do you think this might be the issue you were seeing? atom/atom#18545 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If you type in
Settings > Editor > Font Familyon macOS or Windows, it will delete your characters as you type.The text was updated successfully, but these errors were encountered: