Skip to content
This repository has been archived by the owner on Sep 7, 2018. It is now read-only.

Close tab button for Macs #179

Closed
partydrone opened this issue Oct 27, 2016 · 4 comments
Closed

Close tab button for Macs #179

partydrone opened this issue Oct 27, 2016 · 4 comments

Comments

@partydrone
Copy link

partydrone commented Oct 27, 2016

It would be nice to maintain consistency by having the close tab button on the left side of tabs for Macs. Some ideas include:

  • a configuration option
  • a separate theme
  • automatically detected based on the OS
@simurai
Copy link
Contributor

simurai commented Oct 28, 2016

This came up already in #95 and was closed as wontfix (for now).

I think if this theme should support it, then only as a configuration option to not mess with people's muscle memory.

There are also these additional options:

@Ben3eeE
Copy link

Ben3eeE commented Oct 28, 2016

@simurai see also atom/tabs#378

@simurai
Copy link
Contributor

simurai commented Oct 28, 2016

yeah, doing it the tabs package would be ideal, but probably hard to not break existing packages/themes. For example the One themes have some custom gradient mask for the text that would need to be switched direction.

arcticicestudio added a commit to nordtheme/atom-ui that referenced this issue Mar 5, 2017
This should be implemented in the "tabs" core package.

References:
atom/tabs#378
atom/one-dark-ui#179
@simurai
Copy link
Contributor

simurai commented Aug 22, 2018

Closing, this is now supported in the theme settings:

image

@simurai simurai closed this as completed Aug 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants