This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Update from nsfw/master to include memory leak fixes #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7
This pull request updates this fork to include some changes in Axosoft/nsfw that mitigate a memory leak on Linux. According to Axosoft#74 there may still be memory leaks, but I don't think those are platform-dependent (i.e., they are related to how events are stored, which is the same across operating systems).
I tested those changes out on a Ubuntu VM, and I confirm they fix the issue. Memory usage stops growing unbounded, and using the reproduction steps in #7 memory stays capped at ~100MB (still more than I would like it to be, but at least it doesn't keep growing forever and is consistent with other platforms).