This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 108
Move to Chrome's fork of Hunspell #50
Open
anaisbetts
wants to merge
30
commits into
master
Choose a base branch
from
bdict
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is working okay in my testing, but still has some weird behavior where the first word is marked as an error if it's capitalized. |
I'm also keen for this functionality, is there anything that's stopping us from merging this? Is there anything still left to do before we can merge this? |
@callodacity The capitalization bug is the only thing stopping us, my lldb skills are lacking, maybe @zcbenz can have a look if he's got a hot second? We're using this as a fork in |
fix(getURLForHunspellDictionary): return correct url for some non-formed bdict
Fix broken build with Xcode 9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves Spellchecker to use the Chromium fork of Hunspell, which supports a format invented by Chromium called "bdict" files. bdict files are smaller and less weird (i.e. no aff files), and we're also guaranteed that Chrome keeps them up-to-date.
Unfortuately, compiling with bdict support disables the built-in support for dic/aff files, so this is a breaking change (though I've tried my best to keep the legacy API compatible).
The breaking change is,
setDictionary
now expects aBuffer
as its second parameter, which is a loaded bdic file:A new method
getURLForHunspellDictionary
now will return the URL to download the dictionary file, given a language code.TODO: