This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Allow non-us-english languages, respect system language default, test cleanup #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications here were tested on Mac; I don't have another platform on which to test.
Problems addressed:
#15 -- by removing the hard-coded setting of the default language.
Cleaned up spec file to remove the redundant test of the setDictionary
Added a more user friendly setLanguage() which calls setDictionary() but doesn't require any knowledge of the dictionary path (could be useful for solving atom/spell-check#21); also allows more robust testing of behaviour on platforms with non-english default languages.
Rearranged spellchecker file so that functions can be read in order from top to bottom.
Testing required:
Do other platforms have the same behaviour on instantiation of the spellchecker -- namely they set a language default based on the system?