This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix Loading non-context-aware native module in renderer #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hal Gentz <[email protected]>
Build for older and newer version of v8
Catch up with atom/node-spellchecker.
commit 0c83612 Merge: 2c0d135 5cbdece Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:04:18 2019 -0700 Merge pull request goddessfreya#4 from goddessfreya/Add-Github-actions Add Github actions commit 5cbdece Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:01:01 2019 -0700 Delete appveyor.yml commit 4ddcbd3 Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:00:49 2019 -0700 Delete .travis.yml commit c6f6c63 Author: Freya Gentz <[email protected]> Date: Thu Dec 19 17:57:45 2019 -0700 Update nodejs.yml commit 84bccbd Author: Freya Gentz <[email protected]> Date: Thu Dec 19 17:55:23 2019 -0700 Update nodejs.yml commit f6720ea Author: Freya Gentz <[email protected]> Date: Thu Dec 19 17:50:59 2019 -0700 Update nodejs.yml commit 514a3f9 Author: Freya Gentz <[email protected]> Date: Thu Dec 19 17:31:31 2019 -0700 Add Github actions Signed-off-by: Freya Gentz <[email protected]>
commit 84b6708 Merge: fef5593 1a0243e Author: Freya Gentz <[email protected]> Date: Thu Dec 19 19:43:16 2019 -0700 Merge pull request goddessfreya#6 from goddessfreya/goddessfreya-patch-1 Add clang testing commit 1a0243e Author: Freya Gentz <[email protected]> Date: Thu Dec 19 19:37:34 2019 -0700 Update nodejs.yml commit 18e838f Author: Freya Gentz <[email protected]> Date: Thu Dec 19 19:35:27 2019 -0700 Delete package-lock.json commit d17cf27 Author: Freya Gentz <[email protected]> Date: Thu Dec 19 19:22:57 2019 -0700 Update nodejs.yml commit 81c5ae6 Author: Freya Gentz <[email protected]> Date: Thu Dec 19 19:12:42 2019 -0700 Update nodejs.yml commit 2db0f18 Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:56:33 2019 -0700 Update nodejs.yml commit 855c3c1 Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:49:38 2019 -0700 Update nodejs.yml commit f80be0a Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:38:49 2019 -0700 Update nodejs.yml commit 3c52d66 Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:35:04 2019 -0700 Update nodejs.yml commit 5fe3493 Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:34:31 2019 -0700 Update nodejs.yml commit 8c41771 Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:34:05 2019 -0700 Update nodejs.yml commit 5bd03fe Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:33:49 2019 -0700 Update nodejs.yml commit aab4c50 Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:33:35 2019 -0700 Update nodejs.yml commit 0e6f86f Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:30:31 2019 -0700 Update nodejs.yml commit fef5593 Merge: 0c83612 e99e477 Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:16:48 2019 -0700 Merge pull request goddessfreya#5 from abetomo/fix_deprecated_callback Fix deprecated callback commit 0c83612 Merge: 2c0d135 5cbdece Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:04:18 2019 -0700 Merge pull request goddessfreya#4 from goddessfreya/Add-Github-actions Add Github actions commit 5cbdece Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:01:01 2019 -0700 Delete appveyor.yml commit 4ddcbd3 Author: Freya Gentz <[email protected]> Date: Thu Dec 19 18:00:49 2019 -0700 Delete .travis.yml commit c6f6c63 Author: Freya Gentz <[email protected]> Date: Thu Dec 19 17:57:45 2019 -0700 Update nodejs.yml commit 84bccbd Author: Freya Gentz <[email protected]> Date: Thu Dec 19 17:55:23 2019 -0700 Update nodejs.yml commit f6720ea Author: Freya Gentz <[email protected]> Date: Thu Dec 19 17:50:59 2019 -0700 Update nodejs.yml commit 514a3f9 Author: Freya Gentz <[email protected]> Date: Thu Dec 19 17:31:31 2019 -0700 Add Github actions commit e99e477 Author: abetomo <[email protected]> Date: Thu Jul 5 10:25:35 2018 +0900 Fix deprecated callback The following warning. ``` ../src/worker.cc: In member function ‘virtual void CheckSpellingWorker::HandleOKCallback()’: ../src/worker.cc:44:25: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated [-Wdeprecated-declarations] callback->Call(2, argv); ``` Signed-off-by: Freya Gentz <[email protected]>
and add "freebsd" case. Co-authored-by: Alexander Krotov <[email protected]>
Signed-off-by: Freya Gentz <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
Loading non-context-aware native module in renderer.PR just extends #130