Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Update package.json to fix nan error #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

crazywolf132
Copy link

Removes the nan error.

../../nan/nan_maybe_43_inl.h:112:15: error: no member named 'ForceSet' in 'v8::Object'
  return obj->ForceSet(isolate->GetCurrentContext(), key, value, attribs);

Removes the nan error.

```
../../nan/nan_maybe_43_inl.h:112:15: error: no member named 'ForceSet' in 'v8::Object'
  return obj->ForceSet(isolate->GetCurrentContext(), key, value, attribs);
```
@shiftkey
Copy link

@crazywolf132 which version of Node/Electron are you seeing this error on?

@crazywolf132
Copy link
Author

Hahahaha, i cant even remember what project this was for. It was that long ago i moved on.

@crazywolf132
Copy link
Author

It should have been the latest of both though.

But i remember it was another module causing it. The only fix was to update this module to the latest Nan.

It was even discussed on a stack overflow if i remember correctly. They were saying to go into this module and edit its package.json, so others wouldn't freak out. So i thought why not just push the fix to you guys.

Then no one has to mess around with anything.

@goddessfreya
Copy link
Contributor

We are now on 0.24, so should be safe to close.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants