HEREDOC highlighting broken #57

wyqydsyq · 2015-01-28T01:42:16Z

I have the following code:

$this->data['text_message'] .= <<<TRACKER
        <!-- Facebook Conversion Code for Checkout Success -->
<script>(function() {
var _fbq = window._fbq || (window._fbq = []);
if (!_fbq.loaded) {
var fbds = document.createElement('script');
fbds.async = true;
fbds.src ='//connect.facebook.net/en_US/fbds.js';
var s =document.getElementsByTagName('script')[0];
s.parentNode.insertBefore(fbds, s);
_fbq.loaded = true;
}
})();
window._fbq = window._fbq || [];
window._fbq.push(['track', '',{'value':'0.00','currency':'AUD'}]);
</script>
<noscript><img height="1" width="1"alt="" style="display:none" src="https://www.facebook.com/tr?ev=&amp;cd[value]=0.00&amp;cd[currency]=AUD&amp;noscript=1"/></noscript> 
TRACKER;

But atom doesn't highlight the contents of the HEREDOC as a string:

The first < is correctly given the appropriate classes (class="string unquoted heredoc php") but the class doesn't persist to any of following tokens:

The text was updated successfully, but these errors were encountered:

winstliu · 2015-01-28T02:23:17Z

Refs #10.

wyqydsyq · 2015-01-28T02:42:03Z

It seems in #10 they're getting the correct behaviour of the heredoc being treated as string until a PHP tag is encountered, my case is only the first character of the heredoc is treated as a string regardless of the heredoc's contents.

halcarleton · 2015-04-21T01:11:53Z

+1

Windows 8.1 / Atom 0.179.0
Ubuntu 14.04 / Atom 0.174.0

Krinkle · 2015-07-03T01:35:48Z

Atom: v1.0.0
atom/language-php: v0.26.0

janbaykara · 2015-08-10T13:30:44Z

Getting the same problem as above, with ' character breaking syntax highlighting. It'd be good if <<<HTML foobar HTML; syntax highlighted packaged code with language-html, too.

Nicolas-Bouteille · 2015-10-22T22:59:40Z

any plan for a fix? I find atom really sexy but I use heredocs a lot on my projects. So I am staying on PHPStorm until it is fixed.

winstliu · 2015-10-22T23:32:20Z

I may be able to take a look at this soon. Depends on how quickly I get my existing language backlog cleared up :).

Nicolas-Bouteille · 2015-10-23T08:50:07Z

awesome :)

Le 23 oct. 2015 à 01:32, Wliu [email protected] a écrit :

I may be able to take a look at this soon. Depends on how quickly I get my existing language backlog cleared up :).

—
Reply to this email directly or view it on GitHub #57 (comment).

Talon1024 · 2015-10-23T22:09:34Z

This is an issue with first-mate ignoring nested repositories.

GuilhemN · 2015-12-22T10:39:10Z

Any news about this?

timbotron · 2016-01-26T17:33:22Z

Just wanted to chime in that this is an issue for me too. Crossing fingers that someone can get to it soon. Thanks in advance for all the hard work!

laviyatziv · 2016-02-12T22:20:07Z

I'm also seeing this. Any patch to be released?

krisj · 2016-03-21T12:00:45Z

This has been dragging on since issue #10 back in 2014. #10

Any joy with making progress on it? Can issues be merged so there is more priority on this?

winstliu · 2016-03-23T18:30:53Z

Any help would be welcome. I'll gladly teach someone the basics if they want to give it a try.

GuilhemN · 2016-03-23T19:25:09Z

@50Wliu isn't #77 what you want?

Skarlso · 2016-12-20T09:20:55Z

Why has this been closed? It's not fixed, and the issue that it mentioned is also a bug which was closed because of this, but there is no fix?!

winstliu · 2016-12-20T16:52:38Z

@Skarlso this issue is clearly still open.

Skarlso · 2016-12-20T16:55:02Z

@50Wliu damn. Argh. Sorry. Messes that one up. :-)

winstliu · 2017-03-12T18:20:55Z

Fixed by #184.

winstliu added the bug label Jan 28, 2015

Talon1024 mentioned this issue May 30, 2015

Don't accept spaces after heredoc beginning identifier. (was: Make Heredoc syntax highlighting work) #77

Closed

winstliu added the help-wanted label Oct 22, 2015

winstliu mentioned this issue Sep 22, 2016

PHP EOP, xml content #155

Closed

UziTech mentioned this issue Feb 19, 2017

temporary fix for heredocs #184

Merged

winstliu closed this as completed Mar 12, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HEREDOC highlighting broken #57

HEREDOC highlighting broken #57

wyqydsyq commented Jan 28, 2015

winstliu commented Jan 28, 2015

wyqydsyq commented Jan 28, 2015

halcarleton commented Apr 21, 2015

Krinkle commented Jul 3, 2015

janbaykara commented Aug 10, 2015

Nicolas-Bouteille commented Oct 22, 2015

winstliu commented Oct 22, 2015

Nicolas-Bouteille commented Oct 23, 2015

Talon1024 commented Oct 23, 2015

GuilhemN commented Dec 22, 2015

timbotron commented Jan 26, 2016

laviyatziv commented Feb 12, 2016

krisj commented Mar 21, 2016

winstliu commented Mar 23, 2016

GuilhemN commented Mar 23, 2016

Skarlso commented Dec 20, 2016

winstliu commented Dec 20, 2016

Skarlso commented Dec 20, 2016

winstliu commented Mar 12, 2017

HEREDOC highlighting broken #57

HEREDOC highlighting broken #57

Comments

wyqydsyq commented Jan 28, 2015

winstliu commented Jan 28, 2015

wyqydsyq commented Jan 28, 2015

halcarleton commented Apr 21, 2015

Krinkle commented Jul 3, 2015

janbaykara commented Aug 10, 2015

Nicolas-Bouteille commented Oct 22, 2015

winstliu commented Oct 22, 2015

Nicolas-Bouteille commented Oct 23, 2015

Talon1024 commented Oct 23, 2015

GuilhemN commented Dec 22, 2015

timbotron commented Jan 26, 2016

laviyatziv commented Feb 12, 2016

krisj commented Mar 21, 2016

winstliu commented Mar 23, 2016

GuilhemN commented Mar 23, 2016

Skarlso commented Dec 20, 2016

winstliu commented Dec 20, 2016

Skarlso commented Dec 20, 2016

winstliu commented Mar 12, 2017