This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Remove babel-eslint #1430
Merged
Remove babel-eslint #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we forget to delegate a method, then the test that actually tests it will fail.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was working on #1428, I encountered a snarl of a problem with
babel-eslintandeslint. As far as I can tell, it involves incompatibilities between the latest releases of both, with a side helping of some fun inconsistencies between the way thatnpmandapmdedupe and flattennode_modules/dependencies. Locking to older versions didn't even seem to help, I suspect because of some change in transitive dependencies.Rather than trying to unravel this, I'm going to see how bad it is to get rid of our
babel-eslintdependency.