Optionally allow to use some improvement to fuzzaldrin. #142
Conversation
| {repositoryForPath} = require './helpers' | ||
| fs = require 'fs-plus' | ||
| {match} = require 'fuzzaldrin' | ||
| fuzzaldrin = require 'fuzzaldrin' | ||
| fuzzaldrin_plus = require 'fuzzaldrin-plus' |
There was a problem hiding this comment.
Super tiny, but can you change this to fuzzaldrinPlus?
|
I've been messing around with this, and it seems like an improvement. Other than the one tiny change, I'm down to merge this. |
Optionally allow to use some improvement to fuzzaldrin.
|
I had a lot of example where current fuzzaldrin was not great, but people don't complain when something works. So maybe we have reversed some of the things that worked well. If it's the case I'll have no problem doing additional tuning. |
|
Sounds good 👍 I'll point them to the https://github.com/jeancroy/fuzzaldrin-plus repo for any issues |
|
This is now in atom/master |
|
❤️ thanks a lot guys |
|
+1 ❤️ |
|
Forgot to say this but: thanks @jeancroy for working on this. You obviously put a ton of work into it. I especially like the discussion in the readme/body of the issue. |
|
Available in fuzzy-finder 0.90.0. Thanks @jeancroy for implementing and driving this! |
|
Took me a bit to realize this option existed in Fuzzy Finder (or that Fuzzy Finder was the source of my frustrations), but once I found it, This is REALLY FREAKING AWESOME! Thanks! 😁 🎆 |
As per this discussion first step is testing new scoring algorithm as an option (disabled by default)
atom/fuzzaldrin#22 (comment)