-
Notifications
You must be signed in to change notification settings - Fork 129
On some folder, Cmd+T always tells me "Project is empty" #111
Comments
It's probably because that directory is in the
Then if you press Cmd+T you will get the screenshot above. |
Have the same problem and yes, I have another git repo above this project that ignores all folders to keep track of some general setting files that are applicable for all projects underneath. So my .gitignore has the line |
Same issue here. |
This is happening here also; I would expect the .gitignore which is up a few levels not to be read as the project itself has its own .git folder; is there a more appropriate place to raise this bug to do with the way ignoredNames are dealt with, or is this with the fuzzy-finder project? |
^ further to this, it seems fuzzy finder is the only thing which is affected, everything else manages alright. So I think this is the correct place for this bug. |
From what I can tell, the issue only seems to be with |
^ can confirm. I have the following structure
If I put "things" in /project/.gitignore then fuzzy finder works as expected with thing1/thing2 folders as project base directories. If I however put in /project/things/.gitignore :
because I want the folder to remain empty in source control, then the fuzzy finder does not work correctly in the same situation. |
Atom core has scandal, which is _all about_ building a list of files in a fairly efficient manner, and thinking about VCS issues and symbolic links and whatnot. Instead of reimplementing pieces of that, just use it. This has the nice side-effect of fixing issue atom#111, because scandal is better at deciding which files should be ignored.
Okay, #152 now includes a spec for this issue. So, regardless of whether my approach is settled on, if someone else wants a starting point for looking at it... |
Here's instructions on how to reproduce this bug https://github.com/chrishiestand/atom-fuzzy-finder-git-bug so we can lose the I traced the code from fuzzy finder -> atom -> git-utils -> libgit2 and I'm not quite sure where the problem lies. If the repo and workdir information are being passed properly I'd imagine the bug is in libgit2 but I haven't spent the time to narrow it down further. I don't know anything about scandal, but it would be great to have this bug fixed :-) |
/cc @joshaber |
It may be of note that Tree View does not share this problem (e.g. it correctly shows the files as not vcs ignored) |
@chrishiestand 🤘 Thanks for the repo and instructions! |
As you can see on the screenshot below:
Atom was started with
atom --safe <directoryname>
.OS X 10.10.3, Atom 1.0.
Other folders work well.
(moved from atom/atom#7520)
The text was updated successfully, but these errors were encountered: