Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

On some folder, Cmd+T always tells me "Project is empty" #111

Closed
vincentisambart opened this issue Jun 29, 2015 · 12 comments
Closed

On some folder, Cmd+T always tells me "Project is empty" #111

vincentisambart opened this issue Jun 29, 2015 · 12 comments

Comments

@vincentisambart
Copy link

As you can see on the screenshot below:
screen shot 2015-06-29 at 08 07 54

Atom was started with atom --safe <directoryname>.
OS X 10.10.3, Atom 1.0.
Other folders work well.
(moved from atom/atom#7520)

@vincentisambart
Copy link
Author

It's probably because that directory is in the .gitignore of its parent directory.
Reproduction:

git clone --depth 1 https://github.com/CocoaPods/Rainforest.git
cd Rainforest
rake bootstrap # you can Ctrl+C as soon as the CocoaPods directory has been cloned
atom --safe CocoaPods

Then if you press Cmd+T you will get the screenshot above.

@michaelaye
Copy link

Have the same problem and yes, I have another git repo above this project that ignores all folders to keep track of some general setting files that are applicable for all projects underneath. So my .gitignore has the line */. Is there a workaround to still be able to use the fuzzy finder?

@spencern
Copy link

spencern commented Jul 7, 2015

Same issue here.
Happening for directories that are .gitignored in parent for me as well.

@maaarghk
Copy link

This is happening here also; I would expect the .gitignore which is up a few levels not to be read as the project itself has its own .git folder; is there a more appropriate place to raise this bug to do with the way ignoredNames are dealt with, or is this with the fuzzy-finder project?

@maaarghk
Copy link

^ further to this, it seems fuzzy finder is the only thing which is affected, everything else manages alright. So I think this is the correct place for this bug.

@aaronjensen
Copy link

From what I can tell, the issue only seems to be with */ being ignored. If you simply ignore CocoaPods it works as expected.

@maaarghk
Copy link

^ can confirm.

I have the following structure

/project
|
|-- things
|--|-- thing1
|--|-- thing2
|--|-- .gitignore
|
|-- .gitignore

If I put "things" in /project/.gitignore then fuzzy finder works as expected with thing1/thing2 folders as project base directories.

If I however put in /project/things/.gitignore :

*
!.gitignore

because I want the folder to remain empty in source control, then the fuzzy finder does not work correctly in the same situation.

@izuzak izuzak added the bug label Jul 31, 2015
kemayo added a commit to kemayo/fuzzy-finder that referenced this issue Nov 12, 2015
Atom core has scandal, which is _all about_ building a list of files
in a fairly efficient manner, and thinking about VCS issues and
symbolic links and whatnot. Instead of reimplementing pieces of that,
just use it.

This has the nice side-effect of fixing issue atom#111, because scandal is
better at deciding which files should be ignored.
kemayo added a commit to kemayo/fuzzy-finder that referenced this issue Dec 3, 2015
@kemayo
Copy link

kemayo commented Dec 3, 2015

Okay, #152 now includes a spec for this issue. So, regardless of whether my approach is settled on, if someone else wants a starting point for looking at it...

@chrishiestand
Copy link

Here's instructions on how to reproduce this bug https://github.com/chrishiestand/atom-fuzzy-finder-git-bug so we can lose the needs-reproduction label.

I traced the code from fuzzy finder -> atom -> git-utils -> libgit2 and I'm not quite sure where the problem lies. If the repo and workdir information are being passed properly I'd imagine the bug is in libgit2 but I haven't spent the time to narrow it down further.

I don't know anything about scandal, but it would be great to have this bug fixed :-)

@winstliu
Copy link
Contributor

winstliu commented May 6, 2016

/cc @joshaber

@winstliu winstliu added the git label May 6, 2016
@chrishiestand
Copy link

It may be of note that Tree View does not share this problem (e.g. it correctly shows the files as not vcs ignored)

@joshaber
Copy link
Contributor

joshaber commented May 6, 2016

@chrishiestand 🤘 Thanks for the repo and instructions!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants