Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

foldingStartMarker and foldingStopMarker ignored? #48

Open
sglyon opened this issue Jun 16, 2015 · 6 comments
Open

foldingStartMarker and foldingStopMarker ignored? #48

sglyon opened this issue Jun 16, 2015 · 6 comments

Comments

@sglyon
Copy link

sglyon commented Jun 16, 2015

When I try to fold text in atom it seems that it is indentation based and these two parts of the TextMate preferences (settings) are ignored.

Are they currently active in atom? If so, where is a good example of their usage so I can try to fix the problem with my grammar?

If not, I suppose this is a request that the feature be added 😄

@sglyon
Copy link
Author

sglyon commented Jun 16, 2015

Also, I should note that I do see I can fold selections. This is great, but is not the same as the start and end textmate markers.

@izuzak
Copy link
Contributor

izuzak commented Jun 22, 2015

@spencerlyon2 Yeah, folding in Atom is currently indentation based. Added the "enhancement" label to this issue so that the team can consider the request 👍.

@sglyon
Copy link
Author

sglyon commented Jun 22, 2015

Great thanks. Hopefully I found the right repo to post the issue under

@jrsconfitto
Copy link

This would be a helpful addition for languages like C# and powershell, which often use regions that don't have indented code underneath them. (C# example)

@Hubro
Copy link

Hubro commented Dec 17, 2015

Is this being actively worked on? Is it on a roadmap somewhere? Being able to customize code folding is a pretty glaring omission from "The Hackable Editor" :P

mathuin added a commit to mathuin/language-knitr that referenced this issue Jun 22, 2017
Knitr considers indented regions valid.  Added support for indented
regions by modifying begin and end regular expressions to permit
zero or more whitespace characters before the tokens.

Also modified folding markers in case atom/first-mate#48 is ever
fixed.
@ThatXliner
Copy link

What's the status on this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants