Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

use fuzzaldrin-plus by default #643

Merged
merged 3 commits into from
Dec 18, 2015
Merged

use fuzzaldrin-plus by default #643

merged 3 commits into from
Dec 18, 2015

Conversation

jeancroy
Copy link
Contributor

For some reason the request to update ac+ got translated to command palette.
Probably not bad but this still need to be done.

@benogle @nathansobo

@benogle benogle added the atom label Dec 18, 2015
@jeancroy
Copy link
Contributor Author

Ok switched to less invasive spec fixing. No need to update anything now.

Only thing that fail is a seemingly unrelated position test
Expected '-161px' to be '-160px'

nathansobo pushed a commit that referenced this pull request Dec 18, 2015
use fuzzaldrin-plus by default
@nathansobo nathansobo merged commit 931841d into atom:master Dec 18, 2015
@nathansobo
Copy link
Contributor

Thanks @jeancroy.

@nathansobo
Copy link
Contributor

Out with 1.4.0-beta3.

@axelson
Copy link

axelson commented Jan 21, 2016

There are some cases where it is not performing optimally. For example see: atom/language-ruby#130 where it is preferring dop over do after typing do.

Also is this still considered experimental even though it is on by default?

@jeancroy
Copy link
Contributor Author

Jason, if you read that thread I beleive it's because of reason outside of
alternate scoring.

Jean Christophe Roy

On Wed, Jan 20, 2016 at 9:49 PM, Jason Axelson [email protected]
wrote:

There are some cases where it is not performing optimally. For example
see: atom/language-ruby#130
atom/language-ruby#130 where it is preferring
dop over do after typing do.

Also is this still considered experimental even though it is on by default?


Reply to this email directly or view it on GitHub
#643 (comment)
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants