Drawer Icon

[mattgraham]

Several times as I've been working I've wanted a UI element to open the drawer; what are your thoughts of adding another octicon (which I will add to the font) in addition to the keyboard shortcut to open the tree view?

[benogle]

I like this. I'm not sure of the correct location for the icon, though. I
dont think it should go on the status bar as it is per split pane. And I
dont know want it to overlap any of the line numbers.

On Fri, Sep 27, 2013 at 8:42 AM, Matt Graham [email protected]:

Several times as I've been working I've wanted a UI element to open the
drawer; what are your thoughts of adding another octicon (which I will add
to the font) in addition to the keyboard shortcut to open the tree view?

[image: drawer]https://f.cloud.github.com/assets/51578/1227070/42c19b78-278b-11e3-9ba8-46a271738d7c.gif

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/892
.

[mcolyer]

I feel like the usual paradigm is to have it at the midpoint of the divider like so:

[mattgraham]

@mcolyer I am a fan of having the drag'able area between the two, however, my goal with the icon is that even when the tree is closed you have a 'visual' to open her back up.

@benogle I'm not sure that the icon in the bottom left of the first split is an issue however, what if when the tree closes the icon is top left in the nav bar? Do we like this better?

Also find it weird that 'esc' closes the tree. I'd vote to have meta-\ open and close the tree and dump the extra key command.

[mcolyer]

I think the UI's I've seen still leave the divider visible when collapsed (just enough so you can click on it). I feel like that might be a better route than shifting the tabs.

[mattgraham]

So the issue I have with that is wasting 20px top down on the left of the editor. Its a lot of wasted pixels that I might want to get right out of the way. Do you have some examples where you've seen this done well? I've started looking at visuals for adding files, folders, etc. also in the same space as my original concept (when open):

[kevinsawicki]

I like the way that bottom looks

[mcolyer]

@mattgraham after looking at all of the applications I could quickly find I didn't find a single example of that UI pattern that I was thinking of. In which case it means it's not common and we shouldn't use it.

I did find several OS X apps patterned after your latest screenshot and I really like that direction, so I'm all on board for that.

[benogle]

But what does that look like closed? I agree that it looks great open, but
I think it's strange to have it hanging into the editor or the status bar
or tabs when closed. I like the idea of a 10px block down the left side of
the editor -- provided it looks similar when the tree-view is open

On Mon, Sep 30, 2013 at 12:58 PM, Matt Colyer [email protected]:

@mattgraham https://github.com/mattgraham after looking at all of the
applications I could quickly find I didn't find a single example of that UI
pattern that I was thinking of. In which case it means it's not common and
we shouldn't use it.

I did find several OS X apps patterned after your latest screenshot and I
really like that direction, so I'm all on board for that.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/892#issuecomment-25399383
.

[probablycorey]

I like the looks of this, but it worries me that this isn't consistent with our tool panel CSS layout. Once the Tree View is closed it doesn't have any footprint, so it can't reflow the other tool panels around the open icon. If we can think of a good way to get this working with CSS I would be down for it, but I can't think of any.

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!