Merge pull request #914 from atom-community/async-update-4upstream

fix: update async package
atom · Mar 4, 2021 · 511ebd1 · 511ebd1
2 parents a6f65c4 + 1b413e5
commit 511ebd1
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -29,7 +29,7 @@
   "dependencies": {
     "@atom/plist": "0.4.4",
     "asar-require": "0.3.0",
-    "async": "~0.9.2",
+    "async": "^3.2.0",
     "colors": "~1.4.0",
     "first-mate": "^7.4.1",
     "fs-plus": "3.x",

diff --git a/src/install.coffee b/src/install.coffee
@@ -518,16 +518,17 @@ class Install extends Command
       ]
 
   cloneFirstValidGitUrl: (urls, cloneDir, options, callback) ->
-    async.detectSeries urls, (url, next) =>
+    async.detectSeries(urls, (url, next) =>
       @cloneNormalizedUrl url, cloneDir, options, (error) ->
-        next(not error)
-    , (result) ->
-      if not result
+        next(null, not error)
+    , (err, result) ->
+      if err or not result
         invalidUrls = "Couldn't clone #{urls.join(' or ')}"
         invalidUrlsError = new Error(invalidUrls)
         callback(invalidUrlsError)
       else
         callback()
+    )
 
   cloneNormalizedUrl: (url, cloneDir, options, callback) ->
     # Require here to avoid circular dependency