🐛 Fix error raised when editor is destroyed during animation

Fixes #438
atom-minimap · Dec 21, 2015 · cb215b6 · cb215b6
1 parent 4cd3cad
commit cb215b6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/minimap-element.js b/lib/minimap-element.js
@@ -1216,6 +1216,8 @@ export default class MinimapElement {
     }
 
     let update = () => {
+      if (!this.minimap) { return }
+
       let passed = this.getTime() - start
       if (duration === 0) {
         progress = 1

diff --git a/spec/minimap-element-spec.js b/spec/minimap-element-spec.js
@@ -566,6 +566,14 @@ describe('MinimapElement', () => {
             return editorElement.getScrollTop() >= 380
           })
         })
+
+        it('stops the animation if the text editor is destroyed', () => {
+          editor.destroy()
+
+          nextAnimationFrame !== noAnimationFrame && nextAnimationFrame()
+
+          expect(nextAnimationFrame === noAnimationFrame)
+        })
       })
 
       describe('dragging the visible area', () => {