🐛 💂‍♂️ Try to use the already retrieve pane when possible

atom-minimap · Dec 10, 2014 · 33dd8cf · 33dd8cf
1 parent 6496aa9
commit 33dd8cf
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/lib/minimap-view.coffee b/lib/minimap-view.coffee
@@ -75,7 +75,7 @@ class MinimapView extends View
   # Creates a new {MinimapView}.
   #
   # editorView - The `TextEditorView` for which displaying a minimap.
-  constructor: (editorView) ->
+  constructor: (editorView, @paneView) ->
     @emitter = new Emitter
     @setEditorView(editorView)
 
@@ -213,8 +213,12 @@ class MinimapView extends View
 
   setEditorView: (@editorView) ->
     @editor = @editorView.getModel()
-    @pane = atom.workspace.paneForItem(@editor)
-    @paneView = atom.views.getView(@pane)
+    if @paneView?
+      @pane = @paneView.getModel()
+    else
+      @pane = atom.workspace.paneForItem(@editor)
+      @paneView = atom.views.getView(@pane)
+
     @renderView?.setEditorView(@editorView)
 
     if @obsPane?

diff --git a/lib/mixins/view-management.coffee b/lib/mixins/view-management.coffee
@@ -87,22 +87,22 @@ class ViewManagement extends Mixin
       @updateAllViews()
 
   onEditorAdded: (editor, pane) ->
-    editorView = atom.views.getView(editor)
-
     MinimapView ||= require '../minimap-view'
 
     editorId = editor.id
+    editorView = atom.views.getView(editor)
     paneView = atom.views.getView(pane)
 
-    return unless paneView?
+    return unless editorView? and paneView?
 
     if (view = @minimapViews[editorId])?
+      view.paneView = paneView
       view.setEditorView editorView
       view.detachFromPaneView()
       view.attachToPaneView()
       return
 
-    view = new MinimapView(editorView)
+    view = new MinimapView(editorView, paneView)
 
     @minimapViews[editorId] = view