Throw an error when a Minimap is created without TextEditor

atom-minimap · Dec 14, 2014 · 2c00c80 · 2c00c80
1 parent 985616a
commit 2c00c80
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/minimap.coffee b/lib/minimap.coffee
@@ -5,7 +5,10 @@ module.exports =
 class Minimap
   DecorationManagement.includeInto(this)
 
-  constructor: ({@textEditor}) ->
+  constructor: ({@textEditor}={}) ->
+    unless @textEditor?
+      throw new Error('Cannot create a minimap without an editor')
+
     @emitter = new Emitter
     @subscriptions = subs = new CompositeDisposable
     @initializeDecorations()

diff --git a/spec/minimap-spec.coffee b/spec/minimap-spec.coffee
@@ -21,6 +21,9 @@ describe 'Minimap', ->
   it 'has an associated editor', ->
     expect(minimap.getTextEditor()).toEqual(editor)
 
+  it 'raise an exceptiono if created without a text editor', ->
+    expect(-> new Minimap).toThrow()
+
   it 'measures the minimap size based on the current editor content', ->
     editor.setText(smallSample)
     expect(minimap.getHeight()).toEqual(20)