🐛 Fix DOM polling requesting an update on every call

We’ll require a forced update only when the element become visible.
atom-minimap · Apr 2, 2015 · 075d1a6 · 075d1a6
1 parent f466703
commit 075d1a6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/minimap-element.coffee b/lib/minimap-element.coffee
@@ -370,7 +370,7 @@ class MinimapElement extends HTMLElement
   # Internal: Polling callback used to detect visibility and size changes.
   pollDOM: ->
     if @isVisible()
-      @requestForcedUpdate() unless !@wasVisible
+      @requestForcedUpdate() unless @wasVisible
 
       @measureHeightAndWidth(false)
 

diff --git a/spec/minimap-element-spec.coffee b/spec/minimap-element-spec.coffee
@@ -267,6 +267,8 @@ describe 'MinimapElement', ->
 
         describe 'from hidden to visible', ->
           beforeEach ->
+            editorElement.style.display = 'none'
+            minimapElement.checkForVisibilityChange()
             spyOn(minimapElement, 'requestForcedUpdate')
             editorElement.style.display = ''
             minimapElement.pollDOM()