Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native fuzzaldrin plus fast #230

Merged
merged 4 commits into from
Nov 1, 2020
Merged

Use native fuzzaldrin plus fast #230

merged 4 commits into from
Nov 1, 2020

Conversation

aminya
Copy link
Member

@aminya aminya commented Oct 29, 2020

This replaces fuzzaldrin plus with fuzzaldrin plus fast which is a native module that uses C++ bindings to perform fast fuzzy-search.

@aminya
Copy link
Member Author

aminya commented Oct 29, 2020

@atom-community Could someone review this?

@aminya
Copy link
Member Author

aminya commented Oct 31, 2020

Do you have access to this repo? How can I become a member? Who is the owner?

@UziTech @smashwilson @saschagehlich @joefitzgerald

@UziTech
Copy link
Member

UziTech commented Oct 31, 2020

I only have permission for sync-settings. I asked a while ago which owners were still active with no response. @atom-community/owners if someone could give me access I wouldn't mind helping maintain more repos in @atom-community

@UziTech
Copy link
Member

UziTech commented Nov 1, 2020

Since fuzzaldrin-plus-fast uses node-gyp this is going to cause the user to rebuild the package on new versions of Atom that update electron. I'm not entirely convinced that is worth a little speed improvement.

Is there a benchmark showing a significant improvement?

@aminya
Copy link
Member Author

aminya commented Nov 1, 2020

Since fuzzaldrin-plus-fast uses node-gyp this is going to cause the user to rebuild the package on new versions of Atom that update electron.

fuzzaldrin-plus-fast ships prebuilt binaries using napi which is forward compatible. They will not need to rebuild.

I'm not entirely convinced that is worth a little speed improvement. Is there a benchmark showing a significant improvement?

It is not a little speed improvement. Depending on the size of candidates the speed improvement can be from 2X to 8X or more speedup.
https://github.com/atom-ide-community/fuzzaldrin-plus-fast/runs/1337477773#step:7:117

@UziTech UziTech merged commit ac903af into atom-community:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants