-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If image, show preview. #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This currently does not work. It does not show the preview.
I am also concerned with the performance impact of this change.
I can’t see anything that would cause a noticeable “performance impact”? |
The previous implementation only adds a class, but this PR renders images (which can take some time to load). We should make the image rendering concurrent and lazy somehow, so it does not affect other functionalities of autocomplete. If the performance impact was noticeable, I will hide it behind an optional config that can be enabled by the users. |
The images are all local. Not sure loading times are going to be worth taking into account. Maybe only auto show files under x MB? |
I have better solutions for this. As part of building the cache, on a WebWorker, we can make tiny icons from the images that can load very fast. See #231 |
b6df48c
to
17750cd
Compare
17750cd
to
1e5a9fd
Compare
Co-Authored-By: Tony Brix <[email protected]>
Look below screenshot. Yes, that's it. 😁
If you want to test add below option to 'config.cson'