-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies #19
Conversation
If I recall correctly, a few dependency upgrades to latest do break the tests. Rather than fully updating them to latest, if there are any dependencies that We share the following (non- [ colors: consider switching to --> "ansicolors": "~0.3.2" that All of these are already in sync with npm@6 at the moment, other than |
I merged this fork's Take a look if you like. CI is passing. I'm not sure upgrading everything like that is actually a good idea, especially the |
npm install && npm audit fix
Apm runs in an external node process. There is no benefit in using the same versions as npm. To make apm truly load faster, we should build it using Parcel to tree-shake the dependencies properly. This is in my TODOs. We can get rid of Grunt by using Parcel. |
The tests don't run correctly after this. I reverted this. We need to bump one by one until the issue shows itself. |
I meant that since apm is a wrapper around npm, if we use the same dependencies that apm's internal copy of npm uses under the hood, we can dedupe.
You can investigate for yourself, but spoiler alert: I know the answer. |
Description of the Change
This bumps the dependencies of apm.
Benefits
Using the last dependencies ensures the latest performance, functionality, and security improvements
Verification
All the tests pass in CI and locally.