Improve ASTER sensor angle calculation. #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tmieslinger
commented
Apr 21, 2020
tmieslinger
commented
- make sensor geometry calculation more efficient and more generic. Apprication is extended to ascending satellite mode (before only descending was covered).
- add sensor geometry for backward looking telescope of channel 3.
lkluft
approved these changes
Apr 21, 2020
typhon/cloudmask/aster.py
Outdated
| @@ -617,79 +619,100 @@ def sensor_angles(self, sensor="vnir"): | |||
| Algorithm Theoretical Basis Document for ASTER Level-1 Data | |||
| Processing (Ver. 3.0).1996. | |||
| """ | |||
| if channel is not "3B": | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Good point.Thanks.
typhon/cloudmask/aster.py
Outdated
Comment on lines
696
to
702
| zenith = np.rad2deg(np.arctan(np.sqrt((h * np.tan(np.deg2rad(P[sensor])) | ||
| + 15 * n)**2 | ||
| + (h * np.tan(np.deg2rad(27.6)) | ||
| / np.cos(np.deg2rad(P[sensor])))**2 | ||
| ) / h | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Did you or your IDE/code formatter chose that style? ;)
You could add a new line before h * np.tan... this gives you way more space to operate in the next line
There was a problem hiding this comment.
personal choice :) but I'm open to the back suggestions
typhon/cloudmask/aster.py
Outdated
Comment on lines
630
to
634
| FOV = {"VNIR": 6.09, | ||
| "VNIRB": 5.19, | ||
| "SWIR": 4.9, | ||
| "TIR":4.9 | ||
| } |
There was a problem hiding this comment.
Picky comment from my side ;) There is two options to format code like this:
- If you know that the dictionary is complete:
FOV = {"VNIR": 6.09, "VNIRB": 5.19, "SWIR": 4.9, "TIR": 4.9}- If it may be extended in the future:
FOV = {
"VNIR": 6.09,
"VNIRB": 5.19,
"SWIR": 4.9,
"TIR": 4.9,
}
lkluft
reviewed
Apr 22, 2020
typhon/cloudmask/aster.py
Outdated
Comment on lines
599
to
597
| """Calculate sensor zenith and azimuth angles. | ||
| Angles are derived for each pixel depending on the channel and the |
There was a problem hiding this comment.
Multi-line docstrings consist of a summary line just like a one-line docstring, followed by a blank line, followed by a more elaborate description. PEP257
* make sensor geometry calculation more efficient and more generic. Apprication is extended to ascending satellite mode (before only descending was covered). * add sensor geometry for backward looking telescope of channel 3.
tmieslinger
force-pushed
the
improve_sensor_angle_calc
branch
from
659d565 to
fdf96ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.