Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for backwards incompatible change in AST library #353

Merged
merged 3 commits into from
Feb 21, 2020

Conversation

lkluft
Copy link
Member

@lkluft lkluft commented Feb 18, 2020

This PR fixes a backwards incompatible change to the ast.Module class that has been introduced in Python 3.8

Python 3.8 introduces a backwards incompatible change in `ast.Module`.
Add working solutions for any Python 3.x version (with version check).

See: https://bugs.python.org/issue35894#msg334808
@lkluft lkluft requested review from olemke and simonpf February 18, 2020 12:34
Copy link
Member

@olemke olemke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I could also successfully build Python 3.8 conda packages now.

@lkluft lkluft merged commit dbb9dfb into atmtools:master Feb 21, 2020
@lkluft lkluft deleted the fix-api-py38 branch February 21, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants