Skip to content

Commit

Permalink
Miscellaneous fixes: add newlines back, remove specific user path inf…
Browse files Browse the repository at this point in the history
…o, and help message update

Removing the final newlines from the expect files was premature and probably a mistake.

http://stackoverflow.com/questions/729692/why-should-files-end-with-a-newline

So, leave it to clients/upstream to deal with newlines at the end of the file.

Also, do not print user path info out in expect files (or other files). e.g., no joelm

Also, list frameworks in help message when specifying invalid ones

Reviewed By: @ptarjan

Differential Revision: D1045907
  • Loading branch information
JoelMarcey authored and sgolemon committed Nov 8, 2013
1 parent ea9704e commit 83fb9cf
Show file tree
Hide file tree
Showing 22 changed files with 3,298 additions and 18,108 deletions.
4 changes: 2 additions & 2 deletions hphp/test/frameworks/results/assetic.expect
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ Assetic\Test\Filter\JSMinPlusFilterTest::testRelativeSourceUrlImportImports
Assetic\Test\Filter\JpegoptimFilterTest::testFilter
S
Assetic\Test\Filter\JpegtranFilterTest::testFilter
HipHop Fatal error: Class undefined: finfo in /data/users/joelm/fbcode/hphp/test/frameworks/frameworks/assetic/tests/Assetic/Test/Filter/FilterTestCase.php on line 21
Fatal
Assetic\Test\Filter\LessFilterTest::testCompressImport
S
Assetic\Test\Filter\LessFilterTest::testFilterLoad
Expand Down Expand Up @@ -705,4 +705,4 @@ Assetic\Test\Util\VarUtilsTest::testGetCombinations with data set #2
Assetic\Test\Util\VarUtilsTest::testGetCombinations with data set #3
.
Assetic\Test\Util\VarUtilsTest::testResolve
.
.
2 changes: 1 addition & 1 deletion hphp/test/frameworks/results/codeigniter.expect
Original file line number Diff line number Diff line change
Expand Up @@ -519,4 +519,4 @@ F
Utf8_test::test_convert_to_utf8
.
Xml_helper_test::test_xml_convert
.
.
2 changes: 1 addition & 1 deletion hphp/test/frameworks/results/composer.expect
Original file line number Diff line number Diff line change
Expand Up @@ -1977,4 +1977,4 @@ Composer\Test\Util\SvnTest::testCredentials with data set #1
Composer\Test\Util\SvnTest::testCredentials with data set #2
F
Composer\Test\Util\SvnTest::testInteractiveString
.
.
4 changes: 2 additions & 2 deletions hphp/test/frameworks/results/doctrine2.expect
Original file line number Diff line number Diff line change
Expand Up @@ -4053,7 +4053,7 @@ Doctrine\Tests\ORM\Tools\SchemaValidatorTest::testRoutingModelSet
Doctrine\Tests\ORM\Tools\SchemaValidatorTest::testValidOneToOneAsIdentifierSchema
.
Doctrine\Tests\ORM\Tools\SetupTest::testDirectoryAutoload
HipHop Fatal error: File not found: /data/users/eletuchy/fbcode/hphp/test/frameworks/frameworks/doctrine2/tests/Doctrine/Tests/ORM/Tools/../../../../../lib/vendor/doctrine-common/lib/Doctrine/Common/ClassLoader.php in /data/users/eletuchy/fbcode/hphp/test/frameworks/frameworks/doctrine2/lib/Doctrine/ORM/Tools/Setup.php on line 47
Fatal
Doctrine\Tests\ORM\UnitOfWorkTest::testCascadedIdentityColumnInsert
.
Doctrine\Tests\ORM\UnitOfWorkTest::testChangeTrackingNotify
Expand All @@ -4069,4 +4069,4 @@ Doctrine\Tests\ORM\UnitOfWorkTest::testNoUndefinedIndexNoticeOnScheduleForUpdate
Doctrine\Tests\ORM\UnitOfWorkTest::testRegisterRemovedOnNewEntityIsIgnored
.
Doctrine\Tests\ORM\UnitOfWorkTest::testSavingSingleEntityWithIdentityColumnForcesInsert
.
.
4 changes: 2 additions & 2 deletions hphp/test/frameworks/results/drupal.expect
Original file line number Diff line number Diff line change
Expand Up @@ -1573,12 +1573,12 @@ Drupal\views\Tests\Plugin\field\CounterTest::testSimpleCounter with data set #2
Drupal\views\Tests\ViewExecutableUnitTest::testBuildThemeFunctions
.
Drupal\views\Tests\ViewsDataHelperTest::testFetchFields
HipHop Fatal error: Undefined function: Drupal\views\Tests\t in /data/users/joelm/fbcode/hphp/test/frameworks/frameworks/drupal/core/modules/views/lib/Drupal/views/Tests/ViewTestData.php on line 214
Fatal
Drupal\views\Tests\ViewsTest::testGetView
.
Drupal\views_ui\Tests\Form\Ajax\RearrangeFilterTest::testStaticMethods
.
Drupal\views_ui\Tests\ViewListControllerTest::testBuildRowEntityList
.
Drupal\views_ui\Tests\ViewUIObjectTest::testEntityDecoration
.
.
2 changes: 1 addition & 1 deletion hphp/test/frameworks/results/facebook-php-sdk.expect
Original file line number Diff line number Diff line change
Expand Up @@ -227,4 +227,4 @@ PHPSDKTestCase::testValidCodeToToken
PHPSDKTestCase::testVideoUpload
.
PHPSDKTestCase::testVideoUploadGraph
.
.
2 changes: 1 addition & 1 deletion hphp/test/frameworks/results/idiorm.expect
Original file line number Diff line number Diff line change
Expand Up @@ -397,4 +397,4 @@ QueryBuilderTest::testWhereNotLike
QueryBuilderTest::testWhereNotNull
.
QueryBuilderTest::testWhereNull
.
.
Loading

0 comments on commit 83fb9cf

Please sign in to comment.