Decrease minimal react version ( closed #84 ) #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pofigizm
changed the title
alexreardon
reviewed
Sep 11, 2017
package.json
Outdated
| @@ -64,13 +64,13 @@ | |||
| "flow-copy-source": "1.2.1", | |||
| "jest": "20.0.4", | |||
| "raf-stub": "2.0.1", | |||
| "react": "15.6.1", | |||
There was a problem hiding this comment.
Can we please keep the dev dependency version the same and just change the peerDependency version?
There was a problem hiding this comment.
It's good practice to use same version in develop. So you can quickly find breaking changes. But, it isn't problem for me. I've done it.
alexreardon
requested changes
Sep 11, 2017
alexreardon
approved these changes
Sep 11, 2017
|
Hi, @alexreardon. |
|
I am deep in work getting #2 finished so i have a bit of tunnel vision. I will be doing a release soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All cli tests passed.
Hand tests is ok.
I did't change
react-domversion, becausereact-dom/test-utilsused in tests (since 15.5)But I made hand tests with
react-dom 15.4.0