Update Hook types to return mixed vs void (addresses #695)
#704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreardon
requested changes
Aug 13, 2018
README.md
Outdated
| @@ -758,7 +758,7 @@ Unfortunately we are [unable to apply this optimisation for you](https://medium. | |||
|
|
|||
| `Draggable` components can be dragged around and dropped onto `Droppable`s. A `Draggable` must always be contained within a `Droppable`. It is **possible** to reorder a `Draggable` within its home `Droppable` or move to another `Droppable`. It is **possible** because a `Droppable` is free to control what it allows to be dropped on it. | |||
|
|
|||
| Every `Draggable` has a _drag handle_. A _drag handle_ is the element that the user interacts with in order to drag a `Draggable`. A _drag handle_ can be a the `Draggable` element itself, or a child of the `Draggable`. | |||
| Every `Draggable` has a _drag handle_. A _drag handle_ is the element that the user interacts with in order to drag a `Draggable`. A _drag handle_ can be a the `Draggable` element itself, or a child of the `Draggable`. A _drag handle should not be an interactive element_, since [event handlers are blocked on nested interactive elements](#interactive-child-elements-within-a-draggable). Proper semantics for accessibility are added to the _drag handle_ element. | |||
There was a problem hiding this comment.
A drag handle should not be an interactive element
Might be a little strong. Technically it can be if you set disableInteractiveElementBlocking
I think if phrased as a warning this would be fine
|
Updated the wording per your request. Let me know if there's anything else! |
|
Looks good to me! Thanks @kylehalleman for submitting this improvement! |
alexreardon
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #695.
edit: Also didn't realize subsequent commits to my fork would be added to the PR...but I was going to submit a new PR for the commit anyway. It's a small README change that clarifies that a drag handle should not be an interactive element. Something I discovered after 30 minutes of wondering why my
buttondrag handle was not working.