Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer crashing if SVGElement is not present #1251

Merged
merged 1 commit into from
Apr 12, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/view/is-type-of-element/is-svg-element.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,11 @@
import getWindowFromEl from '../window/get-window-from-el';

export default function isSvgElement(el: Object): boolean %checks {
return el instanceof getWindowFromEl(el).SVGElement;
// Some environments do not support SVGElement
// Doing a double lookup rather than storing the window
// as a %checks function can only be a 'simple predicate'
return (
Boolean(getWindowFromEl(el).SVGElement) &&
el instanceof getWindowFromEl(el).SVGElement
);
}
8 changes: 8 additions & 0 deletions test/unit/view/is-type-of-element/is-svg-element.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,11 @@ it('should not allow html elements from another window', () => {

expect(isSvgElement(anchor)).toBe(false);
});

it('should not crash if the environment does not support SVGElement', () => {
const other = new JSDOM(`<!DOCTYPE html><p>Hello world</p>`);
const anchor: HTMLElement = other.window.document.createElement('a');
anchor.ownerDocument.defaultView.SVGElement = undefined;

expect(isSvgElement(anchor)).toBe(false);
});