[Rest] Support exponential backoff and retry with urllib3 < 2 and new retry parameters #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladimirBabaev
approved these changes
Jan 21, 2025
Viktxrrr
force-pushed
the
master
branch
2 times, most recently
from
adae8fb to
7bba084
Compare
… retry parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating the library to version 3.41.18, the request method stopped working correctly due to the absence of the "Retry-After" header in the Confluence response.
I was getting a KeyError when the response had a status code of 429.
I also decided to add backoff_and_retry support with urllib3 < 2 version, since someone else might be using urllib3 <2. I think this would be a more expected behavior if, when enabling the backoff_and_retry function with urllib3 version <2, it worked anyway.