Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Remote link: Application #1429

Conversation

IncandescentChrysalis
Copy link
Contributor

@IncandescentChrysalis IncandescentChrysalis commented Jul 3, 2024

Fixes #1448

Adding a link to an application connected with a Jira instance through the /rest/api/2/issue/{issueIdOrKey}/remotelink Jira API route, an application section might be provided.
This might for instance be used to add Confluence links to a connected Confluence instance.
Cf. Atlassian knowledge base about the different kind of links.

This PR add an application parameter to the create_or_update_issue_remote_links function.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 31.73%. Comparing base (42ed0b0) to head (9d5fd0a).

Files Patch % Lines
atlassian/jira.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
- Coverage   34.38%   31.73%   -2.65%     
==========================================
  Files          46       46              
  Lines        8586     8258     -328     
  Branches     1601     1296     -305     
==========================================
- Hits         2952     2621     -331     
- Misses       5511     5521      +10     
+ Partials      123      116       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IncandescentChrysalis IncandescentChrysalis force-pushed the add/remote-link/application branch from 9d5fd0a to a177571 Compare July 5, 2024 15:47
@IncandescentChrysalis
Copy link
Contributor Author

IncandescentChrysalis commented Jul 17, 2024

@gonchik I added a test case 2 weeks ago, but it seems the second attempt seems not to have run the actual checks, as there is not output nor logs.
Has the waiting period expired on those checks?

@gonchik gonchik merged commit 4780acc into atlassian-api:master Aug 30, 2024
4 of 10 checks passed
@gonchik
Copy link
Member

gonchik commented Aug 30, 2024

Thanks @IncandescentChrysalis
let me merge and do local tests

gonchik added a commit that referenced this pull request Aug 30, 2024
gonchik added a commit that referenced this pull request Aug 30, 2024
@gonchik
Copy link
Member

gonchik commented Aug 30, 2024

@IncandescentChrysalis as I see issue with tests, could you double check the tests please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add issue remote link
2 participants