Skip to content

Commit

Permalink
Merge pull request #1217 from atlanhq/APP-4617
Browse files Browse the repository at this point in the history
Removes (noop) test auth button from object store inputs
  • Loading branch information
cmgrote authored Jan 14, 2025
2 parents e79b3b8 + 2b1706e commit 92d3461
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 0 deletions.
7 changes: 7 additions & 0 deletions package-toolkit/config/src/main/resources/Config.pkl
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,9 @@ class Widget {

/// SQL query to run to determine the widget's selectable content.
query: String?

/// Whether to prevent the Test Authentication button from showing (true) or show it (false) for credential inputs.
isTestAuthenticationDisabled: Boolean?
}

/// Widget that allows you to enter arbitrary text into a single-line text input field,
Expand Down Expand Up @@ -965,10 +968,14 @@ class CredentialInput extends UIElement {
/// Type of credential to be nested within the widget.
hidden credType: String

/// Whether to show the button for testing authentication. (Default: true, show it)
hidden allowTestAuthentication: Boolean = true

/// (Generated) Internal configuration for the UI's rendering.
fixed ui {
widget = "credential"
credentialType = credType
isTestAuthenticationDisabled = !allowTestAuthentication
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ uiConfig {
required = true
credType = "csa-connectors-objectstore"
helpText = "Enter details for the object store to which to upload the exported file."
allowTestAuthentication = false
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ uiConfig {
required = true
credType = "csa-connectors-objectstore"
helpText = "Enter details for the object store to which to upload the exported file."
allowTestAuthentication = false
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ uiConfig {
required = true
credType = "csa-connectors-objectstore"
helpText = "Enter details for the object store to which to upload the exported file(s)."
allowTestAuthentication = false
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ uiConfig {
required = true
credType = "csa-connectors-objectstore"
helpText = "Enter details for the object store from which to retrieve the file(s) containing metadata to be imported."
allowTestAuthentication = false
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ uiConfig {
required = true
credType = "csa-connectors-objectstore"
helpText = "Enter details for the object store from which to retrieve the file(s) containing cube assets to be imported."
allowTestAuthentication = false
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ uiConfig {
required = true
credType = "csa-connectors-objectstore"
helpText = "Enter details for the object store from which to retrieve the file(s) containing lineage details to be imported."
allowTestAuthentication = false
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ uiConfig {
required = true
credType = "csa-connectors-objectstore"
helpText = "Enter details for the object store to which to upload the exported file."
allowTestAuthentication = false
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ uiConfig {
required = true
credType = "csa-connectors-objectstore"
helpText = "Enter details for the object store from which to retrieve the OpenAPI spec containing metadata to be imported."
allowTestAuthentication = false
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ uiConfig {
required = true
credType = "csa-connectors-objectstore"
helpText = "Select how you want to provide the file containing relational assets to be imported."
allowTestAuthentication = false
}
}
}
Expand Down

0 comments on commit 92d3461

Please sign in to comment.