Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in Exception message #975

Closed
wants to merge 1 commit into from
Closed

Mistake in Exception message #975

wants to merge 1 commit into from

Conversation

TheNetworkIsDown
Copy link
Contributor

The actual function to be called would be initLayout(), not setLayout(), which does not exist.

The actual function to be called would be initLayout(), not setLayout(), which does not exist.
@update-docs
Copy link

update-docs bot commented Mar 8, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.

@codecov
Copy link

codecov bot commented Mar 8, 2020

Codecov Report

Merging #975 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #975   +/-   ##
==========================================
  Coverage      71.42%   71.42%           
  Complexity      2663     2663           
==========================================
  Files            126      126           
  Lines           6254     6254           
==========================================
  Hits            4467     4467           
  Misses          1787     1787
Impacted Files Coverage Δ Complexity Δ
src/App.php 79.16% <0%> (ø) 138 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f12bac...d4c52c0. Read the comment docs.

Copy link
Collaborator

@abbadon1334 abbadon1334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good catch!
but now can be much better to divide the error from the solution like this :

$e = new Exception('App layout is missing');
$e->addSolution('If you use $app->add() you should first call $app->setLayout()');
throw $e;

Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are actually more mentions of setLayout in docs and source code. I will fix that too afterwards.
Thanks!

Edit: I will create and merge new PR instead of this because I'm unable to add anything to your branch. There should be more fixes there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants