Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl. clearable dropdown #2209

Merged
merged 17 commits into from
Jan 10, 2025
Merged

Impl. clearable dropdown #2209

merged 17 commits into from
Jan 10, 2025

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jun 1, 2024

simillar to 6fcc1f2

fix #572
fix #2026

@mvorisek mvorisek force-pushed the clearable_dropdown branch 2 times, most recently from 99509b2 to 1fde92a Compare June 18, 2024 14:30
@mvorisek mvorisek force-pushed the clearable_dropdown branch 2 times, most recently from e30c12a to 1f450c5 Compare January 9, 2025 20:46
@mvorisek mvorisek force-pushed the clearable_dropdown branch 2 times, most recently from f0e6f8a to 47899f6 Compare January 10, 2025 08:58
@mvorisek mvorisek marked this pull request as ready for review January 10, 2025 11:26
@mvorisek mvorisek added the MAJOR label Jan 10, 2025
@mvorisek mvorisek merged commit dcb3ffa into develop Jan 10, 2025
49 checks passed
@mvorisek mvorisek deleted the clearable_dropdown branch January 10, 2025 13:41
@mkrecek234
Copy link
Contributor

Hi @mvorisek With this PR, Lookup fields always get a clearable icon if they are either nullable or not required. I am of the opinion that

a) clearable should only be activated by default if the field is not required and is nullable at the same time
b) it should still be possible to override this default behaviour using setDropdownOption('clearable', false) - currently not possible as it is forced on rendering.

Furthermore I saw that on a disabled/readOnly field with `multiple = true, the clearable icon was present allowing the erase the dropdown field.

Let me know if you agree, then I can work on a PR to suggest a change.

@mvorisek
Copy link
Member Author

Hi Michael, "almost always clearable" - what are the usecases? User should be able to revert any chenge he did on the UI side, so after selecting an option it should be always possible to clear it. The validation on send is of course always working.

"multiple" - if there is an issue, PR with testcase highly welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants