-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impl. clearable dropdown #2209
Impl. clearable dropdown #2209
Conversation
99509b2
to
1fde92a
Compare
1fde92a
to
01a7511
Compare
01a7511
to
8adb06b
Compare
8adb06b
to
e0ba76a
Compare
e0ba76a
to
a869996
Compare
e30c12a
to
1f450c5
Compare
f0e6f8a
to
47899f6
Compare
c46b876
to
5b1388a
Compare
Hi @mvorisek With this PR, Lookup fields always get a clearable icon if they are either nullable or not required. I am of the opinion that a) clearable should only be activated by default if the field is not required and is nullable at the same time Furthermore I saw that on a disabled/readOnly field with `multiple = true, the clearable icon was present allowing the erase the dropdown field. Let me know if you agree, then I can work on a PR to suggest a change. |
Hi Michael, "almost always clearable" - what are the usecases? User should be able to revert any chenge he did on the UI side, so after selecting an option it should be always possible to clear it. The validation on send is of course always working. "multiple" - if there is an issue, PR with testcase highly welcomed! |
simillar to 6fcc1f2
fix #572
fix #2026