Fix ob_end_flush() in JsSse init #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Feb 24, 2024
src/JsSse.php
Outdated
| ob_end_flush(); | ||
| } | ||
| flush(); |
There was a problem hiding this comment.
please explain why flush() is helpful
also note there is self::flush()
There was a problem hiding this comment.
please explain why
flush()is helpful
I don't know. The code is taken from the example I gave. If you think it is not needed, delete it.
There was a problem hiding this comment.
This was the cause of CI failure, as it prevented HTTP code to be set later.
Does this PR now fixes your issue with output buffering together with #2175 (comment) framework you use?
mvorisek
reviewed
Feb 24, 2024
|
we should fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gist.github.com/connerbw/a2fa7712efe135d5854f4d32d67ca09f#file-eventemitter-php-L114