Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop $useRequestUrl param from App::url() method #2107

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Sep 14, 2023

if needed, just pass the dropped code as $page argument

also note the dropped code can be written as non-string as:

$request = $app->getRequest();
$page = [0 => $request->getUri()->getPath()] + $request->getQueryParams();

@mvorisek mvorisek marked this pull request as ready for review September 14, 2023 20:59
@mvorisek mvorisek merged commit f1277b7 into develop Sep 14, 2023
@mvorisek mvorisek deleted the drop_use_request_url branch September 14, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant