Replace $_GET/$_POST/$_FILES with App::getRequestXxx() #2101

abbadon1334 · 2023-09-05T18:57:33Z

fix #2009

… not present

src/App.php

demos/init-app.php

mvorisek · 2023-09-30T11:34:45Z

Thank you @abbadon1334, quality PR!

abbadon1334 added 30 commits August 25, 2023 22:34

Fix PrettyUrl legitimate path

7fdbbe7

Add Unit tests for App::url

ba90e32

add default excepted page and extension

f2dd8f3

fix 7.4 array merge with keys / spread operator

6713d61

Add more test cases for App:url

04720c5

Reorganize code

80b8fca

Improve converage

27d9cb4

Improve App::url tests

67f0594

Skip $useRequestUrl=true due to REQUEST_URI

b2810b8

Change REQUEST_URI to Psr7 methods

3997714

Allow $useRequestUrl=true

4348ff1

clean up

e4c3428

Improve error message

7895ec9

CS Fix

f1fefac

Merge branch 'develop' into add_tests_app_url

308cc87

Add App::$urlBuildingPage to customize url building page

23a5a6b

Comment out App::url failing tests

f3f099f

Merge branch 'develop' into fix_pretty_url_legitimate_path

3c36038

Avoid change of global var $_SERVER

534cff4

Fix missing request in App for Unit tests

a01c3bb

Comment out not working tests

62f370b

removed getRequestUrl

8b3561e

Add failing tests

b6ae878

Add methods App::issetRequestXxx App::getRequestXxx

c7840f1

Replaced all $_FILES

f7e819a

Replace $_GET App::getRequestGetParam

279f796

Replace $_GET App::getRequestGetParam

c2e175c

Replace $_GET App::getRequestGetParam

e4fb8ab

Add App::tryGetRequestGetParam not raise exceptiona nd return null if…

029580c

… not present

Replace $_GET App::has/get/tryGet/RequestGetParam

f7bf3fb

mvorisek force-pushed the use_request_not_globals branch 3 times, most recently from 53f400c to e4a135f Compare September 26, 2023 09:58

atk4 deleted a comment from abbadon1334 Sep 26, 2023

mvorisek force-pushed the use_request_not_globals branch 2 times, most recently from 6940806 to 6143477 Compare September 26, 2023 10:32

mvorisek reviewed Sep 26, 2023

View reviewed changes

src/App.php Outdated Show resolved Hide resolved

mvorisek force-pushed the use_request_not_globals branch from 73e029a to 7400e93 Compare September 26, 2023 11:51

mvorisek reviewed Sep 26, 2023

View reviewed changes

demos/init-app.php Outdated Show resolved Hide resolved

mvorisek added 12 commits September 28, 2023 10:22

add App request shortcut methods

2ed9348

replace all 'isset\(\$_GET\[(.+?)\]' matches

836ade9

replace all '\$_GET\[(.+?)\](?= \?\?)' matches

6b92214

replace all '\$_GET\[(.+?)\]' matches

46f02ec

replace all '\$_POST\[(.+?)\](?= \?\?)' matches

eb936bc

replace all '\$_POST\[(.+?)\]' matches

bfcead2

replace remaining $_GET/$_POST

6ccd09e

rename "GetParam" to "QueryParam"

487903a

replace/emulate $_FILES

994cc1f

fix $_SERVER emulation for POST test

4dd1121

add edge cases empty GET param test

fb349fd

test all exceptions

e63de0a

mvorisek force-pushed the use_request_not_globals branch from 7400e93 to e63de0a Compare September 28, 2023 08:24

mvorisek added 3 commits September 28, 2023 10:24

unset $_GET, $_POST, ... after App is created in demos/testing

acd263e

fix phpstan

f6faa97

fix $_COOKIE unset in demos

78ad102

mvorisek force-pushed the use_request_not_globals branch from f6b89d8 to 78ad102 Compare September 30, 2023 11:08

mvorisek marked this pull request as ready for review September 30, 2023 11:13

mvorisek merged commit 8dd4f7b into develop Sep 30, 2023

mvorisek deleted the use_request_not_globals branch September 30, 2023 11:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace $_GET/$_POST/$_FILES with App::getRequestXxx() #2101

Replace $_GET/$_POST/$_FILES with App::getRequestXxx() #2101

abbadon1334 commented Sep 5, 2023 •

edited by mvorisek

Loading

mvorisek commented Sep 30, 2023

Replace $_GET/$_POST/$_FILES with App::getRequestXxx() #2101

Replace $_GET/$_POST/$_FILES with App::getRequestXxx() #2101

Conversation

abbadon1334 commented Sep 5, 2023 • edited by mvorisek Loading

mvorisek commented Sep 30, 2023

abbadon1334 commented Sep 5, 2023 •

edited by mvorisek

Loading