Form onChange handler for clearing prompts is not needed #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
rm_onchange_handler
branch
from
aaf0d14 to
db15bb0
Compare
mvorisek
changed the title
mvorisek
force-pushed
the
rm_onchange_handler
branch
from
db15bb0 to
077d645
Compare
mvorisek
force-pushed
the
rm_onchange_handler
branch
from
077d645 to
bb68815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
form prompts are removed by https://github.com/atk4/ui/blob/4.0.0/src/Form.php#L554
but not for form dropdowns - fomantic/Fomantic-UI#2797 needs to be fixed first
introduced in 90b0fce#diff-92886d01da016b7104e7ce311d6bed7236b2b6dfae8e378f9a4e53d568b8aae1R120