-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Grid IPP selector #2017
Fix Grid IPP selector #2017
Conversation
needs a Behat test and explanation why set should be done using string, also do not forget, IPP must be definitely typecasted with UI persistence :) |
@mvorisek Even if you raised now the bar to enforce behat tests, I cannot provide this, as it drives efforts to fix newly introduced bugs significantly, even though the fix is simply like in this case. This bug is really annoying, as it destroys the IPP functionality simply. So I would welcome either a merge by you, or any contribution by you to make it ready-to-merge also based on your lifted requirements. |
Michael, adding a Behat test is not so complicated, but it is needed to prevent such bug from happening again. Also please understand the fix is not correct as explained in my post above. |
Thank you @mkrecek234, no one can break it now :) |
fix #2016