Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Grid IPP selector #2017

Merged
merged 7 commits into from
Jun 19, 2023
Merged

Fix Grid IPP selector #2017

merged 7 commits into from
Jun 19, 2023

Conversation

mkrecek234
Copy link
Contributor

@mkrecek234 mkrecek234 commented Mar 2, 2023

fix #2016

@mvorisek
Copy link
Member

mvorisek commented Mar 2, 2023

needs a Behat test and explanation why set should be done using string, also do not forget, IPP must be definitely typecasted with UI persistence :)

@mvorisek mvorisek changed the title Fix issue #2016 Fix broken Grid IPP selector Mar 2, 2023
@mkrecek234
Copy link
Contributor Author

@mvorisek Even if you raised now the bar to enforce behat tests, I cannot provide this, as it drives efforts to fix newly introduced bugs significantly, even though the fix is simply like in this case. This bug is really annoying, as it destroys the IPP functionality simply. So I would welcome either a merge by you, or any contribution by you to make it ready-to-merge also based on your lifted requirements.

@mkrecek234 mkrecek234 requested a review from DarkSide666 April 16, 2023 05:28
@mvorisek
Copy link
Member

mvorisek commented Apr 16, 2023

Michael, adding a Behat test is not so complicated, but it is needed to prevent such bug from happening again.

Also please understand the fix is not correct as explained in my post above.

@mvorisek mvorisek changed the title Fix broken Grid IPP selector Fix Grid IPP selector Jun 18, 2023
@mvorisek
Copy link
Member

Thank you @mkrecek234, no one can break it now :)

@mvorisek mvorisek merged commit c093efc into develop Jun 19, 2023
@mvorisek mvorisek deleted the fix_ipp branch June 19, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid IPP change is broken
2 participants