Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify CardDeck toast with Crud #2010

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Unify CardDeck toast with Crud #2010

merged 2 commits into from
Feb 28, 2023

Conversation

mkrecek234
Copy link
Contributor

CardDeck's JsToast colour is white upon completion of UserAction, whereas Crud's JsToast colour is green.
This PR unifies it to green.

mvorisek
mvorisek reviewed Feb 28, 2023
View reviewed changes
src/CardDeck.php Outdated Show resolved Hide resolved
@mvorisek
Copy link
Member

Thank you. The

ui/src/Js/JsToast.php

Line 37 in 3c592b8

$this->settings['class'] = $this->defaultCss;
is problematic as setDefault/seeding is called after and JS expressions has no init in general.

@mvorisek mvorisek merged commit 20d02be into develop Feb 28, 2023
@mvorisek mvorisek deleted the unify_carddeck_crud_jstoast branch February 28, 2023 17:27
@mvorisek mvorisek changed the title Unify JsToast success colour for CardDeck with Crud's design Unify CardDeck toast with Cru Feb 28, 2023
@mvorisek mvorisek changed the title Unify CardDeck toast with Cru Unify CardDeck toast with Crud Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvorisek mvorisek mvorisek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkrecek234 @mvorisek