Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Fomantic-UI proxied $.extend() #1998

Merged
merged 5 commits into from
Feb 17, 2023
Merged

Fix Fomantic-UI proxied $.extend() #1998

merged 5 commits into from
Feb 17, 2023
+13 −15

Conversation

mvorisek
Copy link
Member

reproducible on /demos/interactive/modal.php, without this PR, the duration from:

ui/js/src/services/modal.service.js

Line 18 in 03a9d65

duration: 100,

was used instead of:

ui/demos/interactive/modal.php

Line 120 in 03a9d65

$transitionModal->setOption('duration', 1000);

@mvorisek mvorisek marked this pull request as ready for review February 17, 2023 12:20
@mvorisek mvorisek merged commit 768d6d6 into develop Feb 17, 2023
@mvorisek mvorisek deleted the fix_fui_extends branch February 17, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mvorisek