Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move non-View JxXxx classes into Js namespace #1872

Merged
merged 4 commits into from
Dec 22, 2022
Merged

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Oct 1, 2022

regex for renamespaced classes:

Ui\\\\?(Jquery|JsChain|JsConditionalForm|JsExpression(able)?|JsFunction|JsModal|JsReload|JsToast|JsVueService)

@mvorisek mvorisek added the MAJOR label Oct 1, 2022
@mvorisek mvorisek force-pushed the reorg_js_classes branch 4 times, most recently from c7256ad to 095aa23 Compare October 1, 2022 19:53
@mvorisek mvorisek marked this pull request as ready for review October 1, 2022 19:54
@mvorisek mvorisek closed this Oct 2, 2022
@mvorisek mvorisek deleted the reorg_js_classes branch October 2, 2022 23:51
@mvorisek mvorisek restored the reorg_js_classes branch December 21, 2022 20:44
@mvorisek mvorisek reopened this Dec 21, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mkrecek234
Copy link
Contributor

Hi @mvorisek For clarification: you want to move those Js classes to sub-namespace as they do not return views? How about JsModal or JsToast - they do return views, whereas JQuery etc. surely not. Not sure what the separating line for you is to decide where to place Js classes. Or move all into sub-namespace?

@mvorisek
Copy link
Member Author

JsModal or JsToast

really?

@mkrecek234
Copy link
Contributor

JsModal triggers to show a modal and JsToast triggers to show a Toast, so in my understanding this is UI-related, even if this happens on the Js layer. Question was solely, what is the distinction for you what to move to Js - if all Js classes, fine; if only non-view related then this might get confusing.

@mvorisek mvorisek changed the title Move non-view JxXxx classes into Js namespace Move non-View JxXxx classes into Js namespace Dec 22, 2022
@mvorisek
Copy link
Member Author

changed title from view to View, JsModal is js utility, but does not create View based modal

@mkrecek234
Copy link
Contributor

Fine for me 👍

@mvorisek mvorisek merged commit 4f3c851 into develop Dec 22, 2022
@mvorisek mvorisek deleted the reorg_js_classes branch December 22, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants