Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Form::addControls() method #1871

Merged
merged 21 commits into from
Oct 1, 2022
Merged

Drop Form::addControls() method #1871

merged 21 commits into from
Oct 1, 2022

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Oct 1, 2022 •
edited
Loading

such method was confusing as the accepted input did not match Model::addFields() and nor implied form group

the removed methods were also never used nor covered

@mvorisek mvorisek marked this pull request as ready for review October 1, 2022 16:06
@mvorisek mvorisek force-pushed the drop_addcontrols branch 3 times, most recently from b8dff87 to b58a1c6 Compare October 1, 2022 18:02
@mvorisek mvorisek merged commit ec83ccb into develop Oct 1, 2022
@mvorisek mvorisek deleted the drop_addcontrols branch October 1, 2022 18:40
mvorisek added a commit that referenced this pull request Oct 17, 2022
@mvorisek
Revert "Drop Form::addControls() method (#1871)"
5092960 
This reverts commit ec83ccb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkrecek234 mkrecek234 Awaiting requested review from mkrecek234

@ibelar ibelar Awaiting requested review from ibelar

@abbadon1334 abbadon1334 Awaiting requested review from abbadon1334

@DarkSide666 DarkSide666 Awaiting requested review from DarkSide666

Assignees
No one assigned
Labels
BC-break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mvorisek