Fix nested accordion open #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
commented
Sep 20, 2022
| @@ -30,7 +30,7 @@ protected function init(): void | |||
| $jsError = [$form->js()->form('add prompt', $fieldName, $str)]; | |||
|
|
|||
| // if a form control is part of an accordion section, it will open that section. | |||
| $section = $form->getClosestOwner($form->getControl($fieldName), AccordionSection::class); | |||
| $section = $form->getControl($fieldName)->getClosestOwner(AccordionSection::class); | |||
There was a problem hiding this comment.
@mkrecek234 the getClosestOwner method was broken, does this fix #1728 too?
There was a problem hiding this comment.
@mkrecek234 should be fixed when not nested
mvorisek
commented
Sep 20, 2022
| protected function renderView(): void | ||
| { | ||
| if ($this->type) { | ||
| $this->addClass($this->type); | ||
| } | ||
|
|
||
| // Only set Accordion in Top container. Otherwise Nested accordion won't work. | ||
| if (!$this->getClosestOwner($this, AccordionSection::class) && !$this->isDynamicSection()) { |
There was a problem hiding this comment.
@ibelar why isDynamicSection was introduced, it is still needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1693
fix (partly - Accordion only) #1728