Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interactive/popup.php cart demo #1793

Merged
merged 1 commit into from
May 21, 2022
Merged

Fix interactive/popup.php cart demo #1793

merged 1 commit into from
May 21, 2022

Conversation

mvorisek
Copy link
Member

fixes #1781

there is destroy method called which smells to me, introduced in ad0fe7e

Behat test should be added to assert the fixed state

@mvorisek mvorisek changed the title Fix "interactive/popup.php" cart demo Fix interactive/popup.php cart demo May 21, 2022
@mvorisek mvorisek force-pushed the fix_popup_cart_demo branch from 49459df to dd66e44 Compare May 21, 2022 18:52
@mvorisek mvorisek marked this pull request as ready for review May 21, 2022 19:15
@mvorisek mvorisek merged commit 4d0935d into develop May 21, 2022
@mvorisek mvorisek deleted the fix_popup_cart_demo branch May 21, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demo broken in interactive/popup.php
1 participant
@mvorisek